Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix javascript bookmarks #1732

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Fix javascript bookmarks #1732

merged 3 commits into from
Oct 1, 2024

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Oct 1, 2024 •
edited
Loading

fixes #1729

@marcelklehr
test: Don't run an initial getBookmarks on each test
cb2ddb1 
To avoid running first-run checks like the javascript feature detection

Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr marcelklehr changed the title test: Don't run an initial getBookmarks on each test Fix javascript bookmarks Oct 1, 2024
@marcelklehr
fix: Run lint:fix
e08bf4c 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix(NextcloudBookmarks): Run javascript feature detection earlier
74056a9 
onSyncStart instead of when getting the tree

Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr marcelklehr merged commit 4d0e2ab into develop Oct 1, 2024
26 of 34 checks passed
@marcelklehr marcelklehr deleted the fix/javascript-bookmarks branch October 1, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScript bookmarks disappearing intermittently
1 participant
@marcelklehr